Discussion:
RFR (M) 8212148: Remove remaining NSK_CPP_STUBs
(too old to reply)
JC Beyler
2018-10-19 01:42:20 UTC
Permalink
Hi all,

Here is the final webrev to remove the NSK_CPP_STUB! Please review the end
of NSK_CPP_STUB.

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148

I've tested the whole vmTestbase since this changed a few shared files. The
whole suite passed on my dev machine.

Let me know what you think,
Jc
Hohensee, Paul
2018-10-19 18:07:44 UTC
Permalink
Looks good.

Paul

From: serviceability-dev <serviceability-dev-***@openjdk.java.net> on behalf of JC Beyler <***@google.com>
Date: Thursday, October 18, 2018 at 9:44 PM
To: "serviceability-***@openjdk.java.net" <serviceability-***@openjdk.java.net>
Subject: RFR (M) 8212148: Remove remaining NSK_CPP_STUBs

Hi all,

Here is the final webrev to remove the NSK_CPP_STUB! Please review the end of NSK_CPP_STUB.

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148

I've tested the whole vmTestbase since this changed a few shared files. The whole suite passed on my dev machine.

Let me know what you think,
Jc
Alex Menkov
2018-10-19 19:02:39 UTC
Permalink
+1

--alex
Post by Hohensee, Paul
Looks good.
Paul
*Date: *Thursday, October 18, 2018 at 9:44 PM
*Subject: *RFR (M) 8212148: Remove remaining NSK_CPP_STUBs
Hi all,
Here is the final webrev to remove the NSK_CPP_STUB! Please review the end of NSK_CPP_STUB.
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8212148/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148
I've tested the whole vmTestbase since this changed a few shared files.
The whole suite passed on my dev machine.
Let me know what you think,
Jc
JC Beyler
2018-10-20 02:40:33 UTC
Permalink
Hi all,

I pushed the webrev into the submit repo and it failed to build due to
internal tests that have references to the NSK_CPP_STUB. Here is the new
webrev:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148

The only difference is I reverted the changes of the nsk_tools.h file which
have the NSK_CPP_STUB. That file now contains the only references to the
NSK_CPP_STUB macros until internally there are no references to them. Then
we can remove the macros from the header file.

Could I please get a new set of LGTM?

(I've re-submitted this to the submit repo and am awaiting results)

Thanks,
Jc
Post by Alex Menkov
+1
--alex
Post by Hohensee, Paul
Looks good.
Paul
*Date: *Thursday, October 18, 2018 at 9:44 PM
*Subject: *RFR (M) 8212148: Remove remaining NSK_CPP_STUBs
Hi all,
Here is the final webrev to remove the NSK_CPP_STUB! Please review the
end of NSK_CPP_STUB.
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8212148/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148
I've tested the whole vmTestbase since this changed a few shared files.
The whole suite passed on my dev machine.
Let me know what you think,
Jc
--
Thanks,
Jc
Igor Ignatyev
2018-10-20 04:04:59 UTC
Permalink
LGTM

-- Igor
Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.01/ <http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.01/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148 <https://bugs.openjdk.java.net/browse/JDK-8212148>
The only difference is I reverted the changes of the nsk_tools.h file which have the NSK_CPP_STUB. That file now contains the only references to the NSK_CPP_STUB macros until internally there are no references to them. Then we can remove the macros from the header file.
Could I please get a new set of LGTM?
(I've re-submitted this to the submit repo and am awaiting results)
Thanks,
Jc
+1
--alex
Post by Hohensee, Paul
Looks good.
Paul
*Date: *Thursday, October 18, 2018 at 9:44 PM
*Subject: *RFR (M) 8212148: Remove remaining NSK_CPP_STUBs
Hi all,
Here is the final webrev to remove the NSK_CPP_STUB! Please review the
end of NSK_CPP_STUB.
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/ <http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/>
<http://cr.openjdk.java.net/%7Ejcbeyler/8212148/webrev.00/ <http://cr.openjdk.java.net/%7Ejcbeyler/8212148/webrev.00/>>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148 <https://bugs.openjdk.java.net/browse/JDK-8212148>
I've tested the whole vmTestbase since this changed a few shared files.
The whole suite passed on my dev machine.
Let me know what you think,
Jc
--
Thanks,
Jc
JC Beyler
2018-10-22 19:24:37 UTC
Permalink
Hi all,

Igor actually finished cleaning up the closed tests, so I can go ahead and
push webrev.00.

Thanks all for your reviews and help :)
Jc
Post by Igor Ignatyev
LGTM
-- Igor
Hi all,
I pushed the webrev into the submit repo and it failed to build due to
internal tests that have references to the NSK_CPP_STUB. Here is the new
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148
The only difference is I reverted the changes of the nsk_tools.h file
which have the NSK_CPP_STUB. That file now contains the only references to
the NSK_CPP_STUB macros until internally there are no references to them.
Then we can remove the macros from the header file.
Could I please get a new set of LGTM?
(I've re-submitted this to the submit repo and am awaiting results)
Thanks,
Jc
Post by Alex Menkov
+1
--alex
Post by Hohensee, Paul
Looks good.
Paul
*Date: *Thursday, October 18, 2018 at 9:44 PM
*Subject: *RFR (M) 8212148: Remove remaining NSK_CPP_STUBs
Hi all,
Here is the final webrev to remove the NSK_CPP_STUB! Please review the
end of NSK_CPP_STUB.
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8212148/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212148
I've tested the whole vmTestbase since this changed a few shared files.
The whole suite passed on my dev machine.
Let me know what you think,
Jc
--
Thanks,
Jc
--
Thanks,
Jc
Loading...