Discussion:
RFR(XXS): 8214108: Incorrect Function parameter lists in some jtreg tests
(too old to reply)
Simon Tooke
2018-11-20 14:41:50 UTC
Permalink
Hello,

I'm not sure if this belongs in the serviceability group, but the tests
are for jvmti, so it seemed appropriate.
Please point me elsewhere if not.

Two tests define a ClassUnload() callback function with an incorrect
parameter,"jvmtiEnv jvmti_env", instead of "jvmtiEnv* jvmti_env".  

This will lead to an invalid cast warning on some compilers, but
currently has no impact on the tests as ex03t001 is disabled, and the
body of the other ClassUnload() is empty. These issues were found by
compiling with GCC 8.1.

Bug: https://bugs.openjdk.java.net/browse/JDK-8214108
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/stooke/JDK-8214108/01/webrev/

For what it's worth, ex03t001 does pass if enabled, but I don't know if the test is correct at this point; it's been disabled for a while.

Please let me know what you think,

Thanks,
-Simon
Gary Adams
2018-11-20 15:30:07 UTC
Permalink
Looks OK to me.

It appears that there were problems in the past with ex03t001
using different GC implementations.

I'd suggest filing a new bug to track moving the test off the ProblemList.
It could be combined with restoring a number of other tests in the
next release timeframe.
Post by Simon Tooke
Hello,
I'm not sure if this belongs in the serviceability group, but the tests
are for jvmti, so it seemed appropriate.
Please point me elsewhere if not.
Two tests define a ClassUnload() callback function with an incorrect
parameter,"jvmtiEnv jvmti_env", instead of "jvmtiEnv* jvmti_env".
This will lead to an invalid cast warning on some compilers, but
currently has no impact on the tests as ex03t001 is disabled, and the
body of the other ClassUnload() is empty. These issues were found by
compiling with GCC 8.1.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214108
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/stooke/JDK-8214108/01/webrev/
For what it's worth, ex03t001 does pass if enabled, but I don't know if the test is correct at this point; it's been disabled for a while.
Please let me know what you think,
Thanks,
-Simon
s***@oracle.com
2018-11-20 18:38:00 UTC
Permalink
Hi Simon,

It looks good.
Thank you for taking care about this!

The same question if you need a sponsor here.

Thanks,
Serguei
Post by Simon Tooke
Hello,
I'm not sure if this belongs in the serviceability group, but the tests
are for jvmti, so it seemed appropriate.
Please point me elsewhere if not.
Two tests define a ClassUnload() callback function with an incorrect
parameter,"jvmtiEnv jvmti_env", instead of "jvmtiEnv* jvmti_env".
This will lead to an invalid cast warning on some compilers, but
currently has no impact on the tests as ex03t001 is disabled, and the
body of the other ClassUnload() is empty. These issues were found by
compiling with GCC 8.1.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214108
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/stooke/JDK-8214108/01/webrev/
For what it's worth, ex03t001 does pass if enabled, but I don't know if the test is correct at this point; it's been disabled for a while.
Please let me know what you think,
Thanks,
-Simon
Severin Gehwolf
2018-11-22 09:02:26 UTC
Permalink
Hi,
Post by s***@oracle.com
Hi Simon,
It looks good.
Thank you for taking care about this!
The same question if you need a sponsor here.
I'll sponsor this for Simon.

Thanks,
Severin
Post by s***@oracle.com
Thanks,
Serguei
Post by Simon Tooke
Hello,
I'm not sure if this belongs in the serviceability group, but the tests
are for jvmti, so it seemed appropriate.
Please point me elsewhere if not.
Two tests define a ClassUnload() callback function with an incorrect
parameter,"jvmtiEnv jvmti_env", instead of "jvmtiEnv* jvmti_env".
This will lead to an invalid cast warning on some compilers, but
currently has no impact on the tests as ex03t001 is disabled, and the
body of the other ClassUnload() is empty. These issues were found by
compiling with GCC 8.1.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214108
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/stooke/JDK-8214108/01/webrev/
For what it's worth, ex03t001 does pass if enabled, but I don't know if the test is correct at this point; it's been disabled for a while.
Please let me know what you think,
Thanks,
-Simon
Loading...