Discussion:
RFR (XS) 8213246: Fix typo in vmTestbase failuire to failure
(too old to reply)
JC Beyler
2018-11-02 23:05:58 UTC
Permalink
Hi all,

Could I get a review for a trivial typo fix:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8213246

Thanks,
Jc
Mikael Vidstedt
2018-11-02 23:22:43 UTC
Permalink
Looks good.

Cheers,
Mikael - not a Reviewer
Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/ <http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8213246 <https://bugs.openjdk.java.net/browse/JDK-8213246>
Thanks,
Jc
Igor Ignatyev
2018-11-02 23:25:36 UTC
Permalink
LGTM

-- Igor - a Reviewer
Post by Mikael Vidstedt
Looks good.
Cheers,
Mikael - not a Reviewer
Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/ <http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8213246 <https://bugs.openjdk.java.net/browse/JDK-8213246>
Thanks,
Jc
JC Beyler
2018-11-03 19:39:09 UTC
Permalink
Thanks all, pushed :)
Jc
Post by Igor Ignatyev
LGTM
-- Igor - a Reviewer
Looks good.
Cheers,
Mikael - not a Reviewer
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8213246
Thanks,
Jc
--
Thanks,
Jc
Daniel D. Daugherty
2018-11-02 23:24:52 UTC
Permalink
Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8213246/webrev.00/>
test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_tools.cpp
    No comments.

test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack001.java
    No comments.

Thumbs up!

Dan
Post by JC Beyler
Bug: https://bugs.openjdk.java.net/browse/JDK-8213246
Thanks,
Jc
Loading...