Discussion:
RFR 8215050: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java fails when run with flag -Xcomp
(too old to reply)
Patricio Chilano
2018-12-08 23:04:23 UTC
Permalink
Hi,

Could you review this small fix for test
serviceability/tmtools/jstack/WaitNotifyThreadTest.java ?
After change 8214148 the test fails if the flag -Xcomp is used as
explained in the bug details. The proposed change is to identified this
special case and set the monitor address to match the one expected.

http://cr.openjdk.java.net/~pchilanomate/8215050.02/webrev/
https://bugs.openjdk.java.net/browse/JDK-8215050

Run tier-4 where the test was failing and passed (the test was failing
on tier6 also because it uses -Xcomp too). Currently running tiers1-3.

Thanks,
Patricio
David Holmes
2018-12-08 23:21:57 UTC
Permalink
Hi Patricio,
Post by Patricio Chilano
Hi,
Could you review this small fix for test
serviceability/tmtools/jstack/WaitNotifyThreadTest.java ?
After change 8214148 the test fails if the flag -Xcomp is used as
explained in the bug details. The proposed change is to identified this
special case and set the monitor address to match the one expected.
http://cr.openjdk.java.net/~pchilanomate/8215050.02/webrev/
https://bugs.openjdk.java.net/browse/JDK-8215050
Run tier-4 where the test was failing and passed (the test was failing
on tier6 also because it uses -Xcomp too). Currently running tiers1-3.
Change seems fine. The lack of address must be something relatively new
as I don't see it with Xcomp in JDK 9.

Thanks,
David
Post by Patricio Chilano
Thanks,
Patricio
Patricio Chilano
2018-12-09 00:42:23 UTC
Permalink
Hi David,
Post by David Holmes
Hi Patricio,
Post by Patricio Chilano
Hi,
Could you review this small fix for test
serviceability/tmtools/jstack/WaitNotifyThreadTest.java ?
After change 8214148 the test fails if the flag -Xcomp is used as
explained in the bug details. The proposed change is to identified
this special case and set the monitor address to match the one expected.
http://cr.openjdk.java.net/~pchilanomate/8215050.02/webrev/
https://bugs.openjdk.java.net/browse/JDK-8215050
Run tier-4 where the test was failing and passed (the test was
failing on tier6 also because it uses -Xcomp too). Currently running
tiers1-3.
Change seems fine. The lack of address must be something relatively
new as I don't see it with Xcomp in JDK 9.
Thanks for the review!


Thanks,
Patricio
Post by David Holmes
Thanks,
David
Post by Patricio Chilano
Thanks,
Patricio
Loading...