RFR (L) 8212082: Remove the NSK_CPP_STUB macros from remaining vmTestbase/jvmti/[sS]*

Discussion:

JC Beyler

2018-10-12 20:40:33 UTC

Hi all,

I am continuing the NSK_CPP_STUB removal with this next webrev (before last
one, the next one I'll send out will be removing NSK_CPP_STUB entirely).

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212082/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212082

The change is still straight-forward though, since it is just doing the
same NSK_CPP_STUB removal as others.

Thanks,
Jc

Hohensee, Paul

2018-10-12 21:16:32 UTC

Permalink

This looks fine. Do the tests run correctly after the transform?

paul

From: serviceability-dev <serviceability-dev-***@openjdk.java.net> on behalf of JC Beyler <***@google.com>
Date: Friday, October 12, 2018 at 4:41 PM
To: "serviceability-***@openjdk.java.net" <serviceability-***@openjdk.java.net>
Subject: RFR (L) 8212082: Remove the NSK_CPP_STUB macros from remaining vmTestbase/jvmti/[sS]*

Hi all,

I am continuing the NSK_CPP_STUB removal with this next webrev (before last one, the next one I'll send out will be removing NSK_CPP_STUB entirely).

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212082/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212082

The change is still straight-forward though, since it is just doing the same NSK_CPP_STUB removal as others.

Thanks,
Jc

JC Beyler

2018-10-12 21:25:22 UTC

Permalink

Yes they do, they have run on my dev machine and I'm submitting it on the
submit repo (though that will test build and not the tests from what I
understood) :)
Jc

Post by Hohensee, Paul
This looks fine. Do the tests run correctly after the transform?
paul
*Date: *Friday, October 12, 2018 at 4:41 PM
*Subject: *RFR (L) 8212082: Remove the NSK_CPP_STUB macros from remaining
vmTestbase/jvmti/[sS]*
Hi all,
I am continuing the NSK_CPP_STUB removal with this next webrev (before
last one, the next one I'll send out will be removing NSK_CPP_STUB
entirely).
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212082/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212082
The change is still straight-forward though, since it is just doing the
same NSK_CPP_STUB removal as others.
Thanks,
Jc

--
Thanks,
Jc

Alex Menkov

2018-10-13 00:16:50 UTC

Permalink

Looks good to me.

--alex

Post by JC Beyler
Yes they do, they have run on my dev machine and I'm submitting it on
the submit repo (though that will test build and not the tests from what
I understood) :)
Jc
This looks fine. Do the tests run correctly after the transform?____
__ __
paul____
__ __
*From: *serviceability-dev
*Date: *Friday, October 12, 2018 at 4:41 PM
*Subject: *RFR (L) 8212082: Remove the NSK_CPP_STUB macros from
remaining vmTestbase/jvmti/[sS]*____
__ __
Hi all,____
I am continuing the NSK_CPP_STUB removal with this next webrev
(before last one, the next one I'll send out will be removing
NSK_CPP_STUB entirely).____
__ __
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212082/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8212082/webrev.00/>____
Bug: https://bugs.openjdk.java.net/browse/JDK-8212082____
__ __
The change is still straight-forward though, since it is just doing
the same NSK_CPP_STUB removal as others. ____
__ __
Thanks,____
Jc____
--
Thanks,
Jc

JC Beyler

2018-10-15 02:08:57 UTC

Permalink

Thanks both :)
Jc

Post by Alex Menkov
Looks good to me.
--alex

--
Thanks,
Jc