RFR JDK-8203928: [Test] Convert non-JDB scaffolding serviceability shell script tests to java

[Alex Menkov]

Hi all,

please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8203928
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/

Some details:

ImmutableResourceTest.java
- required compile/run args are specified by using jtreg tag options;

JITDebug.java
- was not able to reproduce failures described (looks like that it's
something ancient). Actually we use dt_socket transport on Windows for a
long time without any issues;
- replaced Runtime.exec with ProcessBuilder, used some /test/lib
stuff, fixed some minor issues;

connect/spi/JdiLoadedByCustomLoader.java
redefine/RedefineTest.java
redefineMethod/RedefineTest.java
- implemented compilation tasks in java, removed shell files;

PrivateTransportTest.java (was test/jdk/com/sun/jdi/PrivateTransportTest.sh)
- just converted the test from shell to java.

--alex

[JC Beyler]

Hi Alex,

Looks good to me, I especially liked the simplification of
the PrivateTransportTest :)
Jc

Post by Alex Menkov
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8203928
http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/
ImmutableResourceTest.java
- required compile/run args are specified by using jtreg tag options;
JITDebug.java
- was not able to reproduce failures described (looks like that it's
something ancient). Actually we use dt_socket transport on Windows for a
long time without any issues;
- replaced Runtime.exec with ProcessBuilder, used some /test/lib
stuff, fixed some minor issues;
connect/spi/JdiLoadedByCustomLoader.java
redefine/RedefineTest.java
redefineMethod/RedefineTest.java
- implemented compilation tasks in java, removed shell files;
PrivateTransportTest.java (was
test/jdk/com/sun/jdi/PrivateTransportTest.sh)
- just converted the test from shell to java.
--alex

[Chris Plummer]

Hi Alex,

Looks good.

thanks,

Chris

Post by Alex Menkov
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8203928
http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/
ImmutableResourceTest.java
  - required compile/run args are specified by using jtreg tag options;
JITDebug.java
  - was not able to reproduce failures described (looks like that it's
something ancient). Actually we use dt_socket transport on Windows for
a long time without any issues;
  - replaced Runtime.exec with ProcessBuilder, used some /test/lib
stuff, fixed some minor issues;
connect/spi/JdiLoadedByCustomLoader.java
redefine/RedefineTest.java
redefineMethod/RedefineTest.java
  - implemented compilation tasks in java, removed shell files;
PrivateTransportTest.java (was
test/jdk/com/sun/jdi/PrivateTransportTest.sh)
  - just converted the test from shell to java.
--alex