Discussion:
КАК JDK-8212665: com/sun/jdi/DeferredStepTest.java: jj1 (line 57) - unexpected. lastLine=52, minLine=52, maxLine=55
(too old to reply)
Alex Menkov
2018-10-18 22:42:29 UTC
Permalink
Hi all,

Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
webrev:
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/

The test verifies that after "next" command debugger always stops in the
position within loops. Each thread has maximum 40 stops (10 iterations,
4 lines each), but with 50 "next" command it's possible that one of the
thread exits the loop.
The fix increments loops to make 15 iterations, so each thread has more
than 50 stops.

--alex
JC Beyler
2018-10-19 02:22:08 UTC
Permalink
Hi Alex,

Looks good to me.

Two nits:
- The loops you changed are using ii as the loop counter, any reason we
would not just put it to i?
- The last comment change, the loop line right under has no spacings, we
could extend the webrev a tiny bit and add some spaces?

There is no need to resend a webrev for these, regardless if you do them or
not :)
Jc
Post by Alex Menkov
Hi all,
Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
The test verifies that after "next" command debugger always stops in the
position within loops. Each thread has maximum 40 stops (10 iterations,
4 lines each), but with 50 "next" command it's possible that one of the
thread exits the loop.
The fix increments loops to make 15 iterations, so each thread has more
than 50 stops.
--alex
--
Thanks,
Jc
g***@oracle.com
2018-10-19 09:16:40 UTC
Permalink
Looks good to me.

Should the comment "58 steps" be "58 stops"?
Post by Alex Menkov
Hi all,
Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
The test verifies that after "next" command debugger always stops in
the position within loops. Each thread has maximum 40 stops (10
iterations, 4 lines each), but with 50 "next" command it's possible
that one of the thread exits the loop.
The fix increments loops to make 15 iterations, so each thread has
more than 50 stops.
--alex
s***@oracle.com
2018-10-22 20:10:35 UTC
Permalink
Hi Alex,

The fix looks good.
+1 for the Jc's suggestion to add spacing to the line:

176 for (int i=0; i<50; i++) {

Thanks,
Serguei
Post by Alex Menkov
Hi all,
Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
The test verifies that after "next" command debugger always stops in
the position within loops. Each thread has maximum 40 stops (10
iterations, 4 lines each), but with 50 "next" command it's possible
that one of the thread exits the loop.
The fix increments loops to make 15 iterations, so each thread has
more than 50 stops.
--alex
Alex Menkov
2018-10-22 21:38:25 UTC
Permalink
Hi Jc, Gary, Serguei,

Just for the record, updated webrev:
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev.01

(spaces are added, "steps" in the comment is replaced with "stops")

--alex
Post by JC Beyler
Hi Alex,
The fix looks good.
 176         for (int i=0; i<50; i++) {
Thanks,
Serguei
Post by Alex Menkov
Hi all,
Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
The test verifies that after "next" command debugger always stops in
the position within loops. Each thread has maximum 40 stops (10
iterations, 4 lines each), but with 50 "next" command it's possible
that one of the thread exits the loop.
The fix increments loops to make 15 iterations, so each thread has
more than 50 stops.
--alex
s***@oracle.com
2018-10-22 21:40:00 UTC
Permalink
LGTM

Thanks,
Serguei
Post by Alex Menkov
Hi Jc, Gary, Serguei,
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev.01
(spaces are added, "steps" in the comment is replaced with "stops")
--alex
Post by JC Beyler
Hi Alex,
The fix looks good.
  176         for (int i=0; i<50; i++) {
Thanks,
Serguei
Post by Alex Menkov
Hi all,
Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
The test verifies that after "next" command debugger always stops in
the position within loops. Each thread has maximum 40 stops (10
iterations, 4 lines each), but with 50 "next" command it's possible
that one of the thread exits the loop.
The fix increments loops to make 15 iterations, so each thread has
more than 50 stops.
--alex
Loading...