Discussion:
RFR: JDK-8213916: no copyright in signature.html
(too old to reply)
Gary Adams
2018-11-15 13:45:18 UTC
Permalink
Here's a quick fix to add a missing copyright to signature.html.


diff --git
a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
--- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
@@ -1,4 +1,29 @@
<!DOCTYPE HTML>
+<!--
+ Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+
+ This code is free software; you can redistribute it and/or modify it
+ under the terms of the GNU General Public License version 2 only, as
+ published by the Free Software Foundation. Oracle designates this
+ particular file as subject to the "Classpath" exception as provided
+ by Oracle in the LICENSE file that accompanied this code.
+
+ This code is distributed in the hope that it will be useful, but WITHOUT
+ ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ version 2 for more details (a copy is included in the LICENSE file that
+ accompanied this code).
+
+ You should have received a copy of the GNU General Public License version
+ 2 along with this work; if not, write to the Free Software Foundation,
+ Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+
+ Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ or visit www.oracle.com if you need additional information or have any
+ questions.
+-->
+
<HTML lang="EN">
<HEAD>
<TITLE>
JC Beyler
2018-11-15 14:41:35 UTC
Permalink
Hi Gary,

Looks good to me (not a reviewer though),
Jc
Post by Gary Adams
Here's a quick fix to add a missing copyright to signature.html.
diff --git
a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
--- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
@@ -1,4 +1,29 @@
<!DOCTYPE HTML>
+<!--
+ Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+
+ This code is free software; you can redistribute it and/or modify it
+ under the terms of the GNU General Public License version 2 only, as
+ published by the Free Software Foundation. Oracle designates this
+ particular file as subject to the "Classpath" exception as provided
+ by Oracle in the LICENSE file that accompanied this code.
+
+ This code is distributed in the hope that it will be useful, but WITHOUT
+ ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ version 2 for more details (a copy is included in the LICENSE file that
+ accompanied this code).
+
+ You should have received a copy of the GNU General Public License version
+ 2 along with this work; if not, write to the Free Software Foundation,
+ Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+
+ Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ or visit www.oracle.com if you need additional information or have any
+ questions.
+-->
+
<HTML lang="EN">
<HEAD>
<TITLE>
--
Thanks,
Jc
Roger Riggs
2018-11-15 16:01:34 UTC
Permalink
Looks fine,  Roger
Post by JC Beyler
Hi Gary,
Looks good to me (not a reviewer though),
Jc
Here's a quick fix to add a missing copyright to signature.html.
diff --git
a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
--- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
@@ -1,4 +1,29 @@
<!DOCTYPE HTML>
+<!--
+ Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+
+ This code is free software; you can redistribute it and/or modify it
+ under the terms of the GNU General Public License version 2 only, as
+ published by the Free Software Foundation.  Oracle designates this
+ particular file as subject to the "Classpath" exception as provided
+ by Oracle in the LICENSE file that accompanied this code.
+
+ This code is distributed in the hope that it will be useful, but WITHOUT
+ ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or
+ FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
License
+ version 2 for more details (a copy is included in the LICENSE file that
+ accompanied this code).
+
+ You should have received a copy of the GNU General Public License version
+ 2 along with this work; if not, write to the Free Software Foundation,
+ Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+
+ Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ or visit www.oracle.com <http://www.oracle.com> if you need
additional information or have any
+ questions.
+-->
+
<HTML lang="EN">
<HEAD>
<TITLE>
--
Thanks,
Jc
s***@oracle.com
2018-11-15 16:29:38 UTC
Permalink
Hi Gary,

+LGTM

Thanks,
Serguei
Post by Roger Riggs
Looks fine,  Roger
Post by JC Beyler
Hi Gary,
Looks good to me (not a reviewer though),
Jc
    Here's a quick fix to add a missing copyright to signature.html.
    diff --git
a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
    --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
    +++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
    <!DOCTYPE HTML>
    +<!--
    + Copyright (c) 2018, Oracle and/or its affiliates. All rights
    reserved.
    + DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
    +
    + This code is free software; you can redistribute it and/or
modify it
    + under the terms of the GNU General Public License version 2
only, as
    + published by the Free Software Foundation.  Oracle designates this
    + particular file as subject to the "Classpath" exception as
provided
    + by Oracle in the LICENSE file that accompanied this code.
    +
    + This code is distributed in the hope that it will be useful, but
    WITHOUT
    + ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or
    + FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
    License
    + version 2 for more details (a copy is included in the LICENSE
    file that
    + accompanied this code).
    +
    + You should have received a copy of the GNU General Public
    License version
    + 2 along with this work; if not, write to the Free Software
    Foundation,
    + Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    +
    + Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA
    94065 USA
    + or visit www.oracle.com <http://www.oracle.com> if you need
    additional information or have any
    + questions.
    +-->
    +
    <HTML lang="EN">
    <HEAD>
    <TITLE>
--
Thanks,
Jc
Loading...