Discussion:
[8u-backport] RFR: JDK-8163083: SocketListeningConnector does not allow invocations with port 0
Fairoz Matte
2018-10-04 05:28:15 UTC
Permalink
Hi,

Kindly review the backport of "JDK-8163083: SocketListeningConnector does not allow invocations with port 0" to 8u

Webrev - http://cr.openjdk.java.net/~fmatte/8163083/webrev.00/

JBS bug - https://bugs.openjdk.java.net/browse/JDK-8163083

JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/d38cb687d631

Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-September/025209.html

Thanks,
Fairoz
Daniil Titov
2018-10-04 15:45:21 UTC
Permalink
Hi Fairoz,

The backport looks good for me.

Thanks!
--Daniil

On 10/3/18, 10:28 PM, "serviceability-dev on behalf of Fairoz Matte" <serviceability-dev-***@openjdk.java.net on behalf of ***@oracle.com> wrote:

Hi,

Kindly review the backport of "JDK-8163083: SocketListeningConnector does not allow invocations with port 0" to 8u

Webrev - http://cr.openjdk.java.net/~fmatte/8163083/webrev.00/

JBS bug - https://bugs.openjdk.java.net/browse/JDK-8163083

JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/d38cb687d631

Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-September/025209.html

Thanks,
Fairoz
Fairoz Matte
2018-10-04 16:08:56 UTC
Permalink
Thanks Daniil...
-----Original Message-----
From: Daniil Titov
Sent: Thursday, October 04, 2018 9:15 PM
Subject: Re: [8u-backport] RFR: JDK-8163083: SocketListeningConnector does
not allow invocations with port 0
Hi Fairoz,
The backport looks good for me.
Thanks!
--Daniil
On 10/3/18, 10:28 PM, "serviceability-dev on behalf of Fairoz Matte"
Hi,
Kindly review the backport of "JDK-8163083: SocketListeningConnector
does not allow invocations with port 0" to 8u
Webrev - http://cr.openjdk.java.net/~fmatte/8163083/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8163083
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/d38cb687d631
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-
dev/2018-September/025209.html
Thanks,
Fairoz
s***@oracle.com
2018-10-04 16:20:50 UTC
Permalink
Hi Daniil,

You have to post your review on 8 update mailing list.
But if I remember correctly Fairoz already got a review.
Fairoz, please, correct me if needed.

Thanks,
Serguei
Post by Daniil Titov
Hi Fairoz,
The backport looks good for me.
Thanks!
--Daniil
Hi,
Kindly review the backport of "JDK-8163083: SocketListeningConnector does not allow invocations with port 0" to 8u
Webrev - http://cr.openjdk.java.net/~fmatte/8163083/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8163083
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/d38cb687d631
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-September/025209.html
Thanks,
Fairoz
s***@oracle.com
2018-10-04 17:17:25 UTC
Permalink
Post by s***@oracle.com
Hi Daniil,
You have to post your review on 8 update mailing list.
But if I remember correctly Fairoz already got a review.
The above is wrong - sorry for the noise.

Thanks,
Serguei
Post by s***@oracle.com
Fairoz, please, correct me if needed.
Thanks,
Serguei
Post by Daniil Titov
Hi Fairoz,
The backport looks good for me.
Thanks!
--Daniil
On 10/3/18, 10:28 PM, "serviceability-dev on behalf of Fairoz Matte"
     Hi,
SocketListeningConnector does not allow invocations with port 0" to 8u
          Webrev - http://cr.openjdk.java.net/~fmatte/8163083/webrev.00/
          JBS bug - https://bugs.openjdk.java.net/browse/JDK-8163083
          JDK12 changeset -
http://hg.openjdk.java.net/jdk/jdk/rev/d38cb687d631
          Review thread -
http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-September/025209.html
          Thanks,
     Fairoz
Loading...