Discussion:
[8u] RFR: 8210647: libsaproc is being compiled without optimization
(too old to reply)
Severin Gehwolf
2018-11-15 14:57:34 UTC
Permalink
Hi,

Could I please get reviews for this 8u backport of JDK-8210647. Since
the build system is different in 8, the patch looks different. For the
Windows build changes I've refactored the make file a bit so as to
facilitate passing opt flags to the compiler.

Bug: https://bugs.openjdk.java.net/browse/JDK-8210647
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/

Testing: We have been using this in Fedora's JDK 8 for a while now and
haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was
kind enough to test this on Windows.

Note: I'll also plan to backport JDK-8210836 and JDK-8212110

Thanks,
Severin
JC Beyler
2018-11-15 16:37:15 UTC
Permalink
Hi Severin,

That does look different (
http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :)

It looks good to me :),
Jc
Post by Severin Gehwolf
Hi,
Could I please get reviews for this 8u backport of JDK-8210647. Since
the build system is different in 8, the patch looks different. For the
Windows build changes I've refactored the make file a bit so as to
facilitate passing opt flags to the compiler.
Bug: https://bugs.openjdk.java.net/browse/JDK-8210647
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/
Testing: We have been using this in Fedora's JDK 8 for a while now and
haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was
kind enough to test this on Windows.
Note: I'll also plan to backport JDK-8210836 and JDK-8212110
Thanks,
Severin
--
Thanks,
Jc
Severin Gehwolf
2018-11-15 16:43:26 UTC
Permalink
Hi JC,
Post by JC Beyler
Hi Severin,
That does look different (
http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :)
It looks good to me :),
Thanks for the review!

Cheers,
Severin
Post by JC Beyler
Jc
Post by Severin Gehwolf
Hi,
Could I please get reviews for this 8u backport of JDK-8210647. Since
the build system is different in 8, the patch looks different. For the
Windows build changes I've refactored the make file a bit so as to
facilitate passing opt flags to the compiler.
Bug: https://bugs.openjdk.java.net/browse/JDK-8210647
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/
Testing: We have been using this in Fedora's JDK 8 for a while now and
haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was
kind enough to test this on Windows.
Note: I'll also plan to backport JDK-8210836 and JDK-8212110
Thanks,
Severin
Erik Joelsson
2018-11-15 16:47:47 UTC
Permalink
Looks ok to me.

/Erik
Post by Severin Gehwolf
Hi,
Could I please get reviews for this 8u backport of JDK-8210647. Since
the build system is different in 8, the patch looks different. For the
Windows build changes I've refactored the make file a bit so as to
facilitate passing opt flags to the compiler.
Bug: https://bugs.openjdk.java.net/browse/JDK-8210647
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/
Testing: We have been using this in Fedora's JDK 8 for a while now and
haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was
kind enough to test this on Windows.
Note: I'll also plan to backport JDK-8210836 and JDK-8212110
Thanks,
Severin
Loading...