RFR (S) 8213721 : [Graal] Tests vmTestbase/nsk/stress/except/except* may be encountering SEGV during out-of-memory conditions

Discussion:

JC Beyler

2018-11-21 03:38:30 UTC

Permalink

Hi all,

Could I get a review for this small change for the except* tests:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8213721/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8213721

The bug contains a good explanation of why this is required.

After the webrev, the tests no longer fail due to a SIGSEV with the flags:

-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler
-XX:+TraceExceptions -Dgraal.PrintCompilation=true -XX:+PrintCompilation
-XX:+TraceDeoptimization

(except010.java failed due to a timeout and except004.java failed due to
an OOME from a Graal thread).

Thanks,
Jc

Chris Plummer

2018-11-21 03:48:44 UTC

Permalink

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi JC,<br>
<br>
I think you need to send this to runtime-dev.<br>
<br>
Chris<br>
<br>
<br>
On 11/20/18 7:38 PM, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGBx5gE_oKg7RjuVM-kSjQxaUa+***@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>Could I get a review for this small change for the
except* tests:</div>
<div><br>
</div>
<div>Webrev: <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8213721/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8213721/webrev.00/</a></div>
<div>Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8213721"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8213721</a><br
clear="all">
<div><br>
</div>
<div>The bug contains a good explanation of why this is
required.</div>
<div><br>
</div>
<div>After the webrev, the tests no longer fail due to a
SIGSEV with the flags: </div>
<div><br>
</div>
<div>-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI
-XX:+UseJVMCICompiler -XX:+TraceExceptions
-Dgraal.PrintCompilation=true -XX:+PrintCompilation
-XX:+TraceDeoptimization </div>
<div><br>
</div>
<div> (except010.java failed due to a timeout and
except004.java failed due to an OOME from a Graal
thread).</div>
<div><br>
</div>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>

JC Beyler

2018-11-21 04:01:44 UTC

Permalink

Done Chris,

Sorry force of habit :)
Jc

Post by Chris Plummer
Hi JC,
I think you need to send this to runtime-dev.
Chris
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213721/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8213721
The bug contains a good explanation of why this is required.
-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler
-XX:+TraceExceptions -Dgraal.PrintCompilation=true -XX:+PrintCompilation
-XX:+TraceDeoptimization
(except010.java failed due to a timeout and except004.java failed due to
an OOME from a Graal thread).
Thanks,
Jc

--
Thanks,
Jc

David Holmes

2018-11-21 04:04:01 UTC

Permalink

Re-directing to hotspot-runtime-dev ...

Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8213721/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8213721
The bug contains a good explanation of why this is required.

This looks good to me - but then I'm biased :)

Thanks,
David

Post by JC Beyler
-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler
-XX:+TraceExceptions -Dgraal.PrintCompilation=true -XX:+PrintCompilation
-XX:+TraceDeoptimization
(except010.java failed due to a timeout and except004.java failed due
to an OOME from a Graal thread).
Thanks,
Jc

s***@oracle.com

2018-11-21 04:14:09 UTC

Permalink

Hi Jc,

It looks good to me too.

Thanks,
Serguei

Post by David Holmes
Re-directing to hotspot-runtime-dev ...

This looks good to me - but then I'm biased :)
Thanks,
David

Post by JC Beyler
-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI
-XX:+UseJVMCICompiler -XX:+TraceExceptions
-Dgraal.PrintCompilation=true -XX:+PrintCompilation
-XX:+TraceDeoptimization
(except010.java failed due to a timeout and except004.java failed
due to an OOME from a Graal thread).
Thanks,
Jc

Tobias Hartmann

2018-11-21 05:42:23 UTC

Permalink

Hi Jc,

this looks good to me as well!

Best regards,
Tobias

Post by s***@oracle.com
Hi Jc,
It looks good to me too.
Thanks,
Serguei

Post by David Holmes
Re-directing to hotspot-runtime-dev ...

This looks good to me - but then I'm biased :)
Thanks,
David

Post by JC Beyler
-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler -XX:+TraceExceptions
-Dgraal.PrintCompilation=true -XX:+PrintCompilation -XX:+TraceDeoptimization
(except010.java failed due to a timeout and except004.java failed due to an OOME from a Graal
thread).
Thanks,
Jc

JC Beyler

2018-11-21 17:40:44 UTC

Permalink

Thanks all, tested & pushed,
Jc

Post by s***@oracle.com
Hi Jc,
this looks good to me as well!
Best regards,
Tobias

Post by s***@oracle.com
Hi Jc,
It looks good to me too.
Thanks,
Serguei

Post by David Holmes
Re-directing to hotspot-runtime-dev ...

This looks good to me - but then I'm biased :)
Thanks,
David

Post by JC Beyler
After the webrev, the tests no longer fail due to a SIGSEV with the
-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI

-XX:+UseJVMCICompiler -XX:+TraceExceptions

Post by s***@oracle.com

Post by David Holmes