Discussion:
RFR (XS) 8211905: Remove multiple casts for EM06 file
JC Beyler
2018-10-09 03:54:55 UTC
Permalink
Hi all,

Seems like there is an over-zealous casting in the file
nsk/jvmti/scenarios/events/EM06/em06t001/em06t001.cpp:

jclassName = (jstring) (jstring) (jstring) (jstring) (jstring) (jstring)
(jstring) (jstring) (jstring) NSK_CPP_STUB3(CallObjectMethod, jni_env,
klass,

This webrev fixes that:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8211905/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8211905

Thanks,
Jc
s***@oracle.com
2018-10-09 03:59:58 UTC
Permalink
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Jc,<br>
<br>
It looks good.<br>
Thank you for fixing it!<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 10/8/18 20:54, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGByzO03upAjgR6WX_BaYAR1d4ehqicM+***@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>Seems like there is an over-zealous casting in the
file <span>nsk/jvmti/scenarios/events/EM06/em06t001/em06t001.cpp: </span><br>
<br>
<span>jclassName = (jstring) (jstring) (jstring) (jstring)
(jstring) (jstring) (jstring) (jstring) (jstring)
NSK_CPP_STUB3(CallObjectMethod, jni_env, klass, </span><br>
<div><br>
</div>
<div>This webrev fixes that:</div>
Webrev: <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8211905/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8211905/webrev.00/</a></div>
<div>Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8211905"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8211905</a><br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>
Chris Plummer
2018-10-09 06:08:33 UTC
Permalink
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Looks good. Any idea what caused it,
other than it was introduced by JDK-8209611?<br>
<br>
Chris<br>
<br>
On 10/8/18 8:54 PM, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGByzO03upAjgR6WX_BaYAR1d4ehqicM+***@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>Seems like there is an over-zealous casting in the
file <span
style="color:rgb(51,51,51);font-family:Arial,sans-serif;font-size:14px">nsk/jvmti/scenarios/events/EM06/em06t001/em06t001.cpp: </span><br
style="color:rgb(51,51,51);font-family:Arial,sans-serif;font-size:14px">
<br
style="color:rgb(51,51,51);font-family:Arial,sans-serif;font-size:14px">
<span
style="color:rgb(51,51,51);font-family:Arial,sans-serif;font-size:14px">jclassName
= (jstring) (jstring) (jstring) (jstring) (jstring)
(jstring) (jstring) (jstring) (jstring)
NSK_CPP_STUB3(CallObjectMethod, jni_env, klass, </span><br
style="color:rgb(51,51,51);font-family:Arial,sans-serif;font-size:14px">
<div><br>
</div>
<div>This webrev fixes that:</div>
Webrev: <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8211905/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8211905/webrev.00/</a></div>
<div>Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8211905"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8211905</a><br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>
David Holmes
2018-10-09 06:14:55 UTC
Permalink
Looks good. Any idea what caused it, other than it was introduced by
JDK-8209611?
It wasn't in the original webrev for 8209611 (no cast at all) so I'm
guessing it was a last minute change that somehow went awry. I wonder if
compilers have a -Wunnecessary_cast warning that may have caught it ;-)

David
Chris
Post by JC Beyler
Hi all,
Seems like there is an over-zealous casting in the file
jclassName = (jstring) (jstring) (jstring) (jstring) (jstring)
(jstring) (jstring) (jstring) (jstring)
NSK_CPP_STUB3(CallObjectMethod, jni_env, klass,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8211905/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8211905/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8211905
Thanks,
Jc
Loading...