Discussion:
RFR JDK-8212197: OpenDataException thrown when constructing CompositeData for StackTraceElement
Mandy Chung
2018-10-15 22:02:27 UTC
Permalink
Webrev:
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8212197/webrev.00/

This simple patch fixes the issue Sven reports [1] where
the order of names and values when creating CompositeData
for StackTraceElement is mismatched.  I keep names/values
in the order of the attributes defined from old to new
version.

Mandy
[1]
http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html
Sven Reimers
2018-10-15 22:05:53 UTC
Permalink
Looks good to me.

Thanks.

Sven
Post by Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8212197/webrev.00/
This simple patch fixes the issue Sven reports [1] where
the order of names and values when creating CompositeData
for StackTraceElement is mismatched. I keep names/values
in the order of the attributes defined from old to new
version.
Mandy
[1]
http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html
--
Sven Reimers

* Senior Expert Software Architect
* Java Champion
* NetBeans Dream Team Member: http://dreamteam.netbeans.org
* Community Leader NetBeans: http://community.java.net/netbeans
Desktop Java:
http://community.java.net/javadesktop
* JUG Leader JUG Bodensee: http://www.jug-bodensee.de
* Duke's Choice Award Winner 2009

* XING: https://www.xing.com/profile/Sven_Reimers8
* LinkedIn: http://www.linkedin.com/in/svenreimers
Daniel Fuchs
2018-10-16 08:52:18 UTC
Permalink
Hi Mandy,

This looks good to me.

best regards,

-- daniel
Post by Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8212197/webrev.00/
This simple patch fixes the issue Sven reports [1] where
the order of names and values when creating CompositeData
for StackTraceElement is mismatched.  I keep names/values
in the order of the attributes defined from old to new
version.
Mandy
[1]
http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html
Alan Bateman
2018-10-16 10:18:58 UTC
Permalink
Post by Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8212197/webrev.00/
This simple patch fixes the issue Sven reports [1] where
the order of names and values when creating CompositeData
for StackTraceElement is mismatched.  I keep names/values
in the order of the attributes defined from old to new
version.
Looks good to me.

-Alan

Loading...