Discussion:
[8u-backport] RFR: 8211909: JDWP Transport Listener: dt_socket thread crash
(too old to reply)
Fairoz Matte
2018-10-18 07:37:06 UTC
Permalink
Hi,

Kindly review the backport of "8211909: JDWP Transport Listener: dt_socket thread crash" to 8u

code is almost cleanly applied.

Webrev - http://cr.openjdk.java.net/~fmatte/8211909/webrev.00/

JBS bug - https://bugs.openjdk.java.net/browse/JDK-8211909

JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/a4d4c609d70c

Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025515.html

Thanks,
Fairoz
David Holmes
2018-10-18 07:50:05 UTC
Permalink
Looks good ! Thanks for doing the backport to 8u.

David
Post by Fairoz Matte
Hi,
Kindly review the backport of "8211909: JDWP Transport Listener: dt_socket thread crash" to 8u
code is almost cleanly applied.
Webrev - http://cr.openjdk.java.net/~fmatte/8211909/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8211909
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/a4d4c609d70c
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025515.html
Thanks,
Fairoz
Fairoz Matte
2018-10-18 07:55:35 UTC
Permalink
Thanks David, for the review...
-----Original Message-----
From: David Holmes
Sent: Thursday, October 18, 2018 1:20 PM
Subject: Re: [8u-backport] RFR: 8211909: JDWP Transport Listener: dt_socket
thread crash
Looks good ! Thanks for doing the backport to 8u.
David
Post by Fairoz Matte
Hi,
dt_socket thread crash" to 8u
Post by Fairoz Matte
code is almost cleanly applied.
Webrev - http://cr.openjdk.java.net/~fmatte/8211909/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8211909
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/a4d4c609d70c
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-
dev/2018-October/025515.html
Post by Fairoz Matte
Thanks,
Fairoz
JC Beyler
2018-10-18 16:10:36 UTC
Permalink
Hi Fairoz,

I compared the original and the port, it looks good to me,
Jc
Post by Fairoz Matte
Thanks David, for the review...
-----Original Message-----
From: David Holmes
Sent: Thursday, October 18, 2018 1:20 PM
dt_socket
thread crash
Looks good ! Thanks for doing the backport to 8u.
David
Post by Fairoz Matte
Hi,
dt_socket thread crash" to 8u
Post by Fairoz Matte
code is almost cleanly applied.
Webrev - http://cr.openjdk.java.net/~fmatte/8211909/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8211909
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/a4d4c609d70c
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-
dev/2018-October/025515.html
Post by Fairoz Matte
Thanks,
Fairoz
--
Thanks,
Jc
Fairoz Matte
2018-10-20 06:08:50 UTC
Permalink
Thanks Jc for the review..

 

From: JC Beyler <***@google.com>
Sent: Thursday, October 18, 2018 9:41 PM
To: Fairoz Matte <***@oracle.com>
Cc: David Holmes <***@oracle.com>; serviceability-***@openjdk.java.net
Subject: Re: [8u-backport] RFR: 8211909: JDWP Transport Listener: dt_socket thread crash

 

Hi Fairoz,

 

I compared the original and the port, it looks good to me,

Jc

 

On Thu, Oct 18, 2018 at 12:55 AM Fairoz Matte <HYPERLINK "mailto:***@oracle.com"***@oracle.com> wrote:

Thanks David, for the review...
-----Original Message-----
From: David Holmes
Sent: Thursday, October 18, 2018 1:20 PM
Subject: Re: [8u-backport] RFR: 8211909: JDWP Transport Listener: dt_socket
thread crash
Looks good ! Thanks for doing the backport to 8u.
David
Post by Fairoz Matte
Hi,
dt_socket thread crash" to 8u
Post by Fairoz Matte
code is almost cleanly applied.
Webrev - http://cr.openjdk.java.net/~fmatte/8211909/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8211909
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/a4d4c609d70c
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-
dev/2018-October/025515.html
Post by Fairoz Matte
Thanks,
Fairoz
 
--
 

Thanks,

Jc
Loading...