Discussion:
RFR(XXS) 8213275 ReplaceCriticalClasses.java fails with jdk.internal.vm.PostVMInitHook not found
(too old to reply)
Ioi Lam
2018-11-27 16:42:47 UTC
Permalink
https://bugs.openjdk.java.net/browse/JDK-8213275
http://cr.openjdk.java.net/~iklam/jdk12/8213275-ReplaceCriticalClasses-missing-PostVMInitHook.v01/

Please review this simple fix. The jdk.internal.vm.PostVMInitHook class
is not in the openjdk so it should be used in a test in the openjdk repo.

It isn't important to test for this particular class. When I wrote the
test, I was just looking for a few classes that are loaded immediately
after JVMTI has exited JVMTI_PHASE_PRIMORDIAL, and PostVMInitHook
happened to be one of those classes.

Since we already test a few other classes such as java/util/Locale, the
fix is simply to remove PostVMInitHook from the test.

Thanks
- Ioi
Aleksey Shipilev
2018-11-27 16:44:57 UTC
Permalink
Post by Ioi Lam
https://bugs.openjdk.java.net/browse/JDK-8213275
http://cr.openjdk.java.net/~iklam/jdk12/8213275-ReplaceCriticalClasses-missing-PostVMInitHook.v01/
Looks good and trivial. Thanks for fixing this.

-Aleksey
Lois Foltan
2018-11-27 16:47:07 UTC
Permalink
Looks good.
Lois
Post by Ioi Lam
https://bugs.openjdk.java.net/browse/JDK-8213275
http://cr.openjdk.java.net/~iklam/jdk12/8213275-ReplaceCriticalClasses-missing-PostVMInitHook.v01/
Please review this simple fix. The jdk.internal.vm.PostVMInitHook
class is not in the openjdk so it should be used in a test in the
openjdk repo.
It isn't important to test for this particular class. When I wrote the
test, I was just looking for a few classes that are loaded immediately
after JVMTI has exited JVMTI_PHASE_PRIMORDIAL, and PostVMInitHook
happened to be one of those classes.
Since we already test a few other classes such as java/util/Locale,
the fix is simply to remove PostVMInitHook from the test.
Thanks
- Ioi
Ioi Lam
2018-11-27 16:50:26 UTC
Permalink
Thanks Lois an Aleksey for the quick review!

- Ioi
Post by Lois Foltan
Looks good.
Lois
Post by Ioi Lam
https://bugs.openjdk.java.net/browse/JDK-8213275
http://cr.openjdk.java.net/~iklam/jdk12/8213275-ReplaceCriticalClasses-missing-PostVMInitHook.v01/
Please review this simple fix. The jdk.internal.vm.PostVMInitHook
class is not in the openjdk so it should be used in a test in the
openjdk repo.
the test, I was just looking for a few classes that are loaded
immediately after JVMTI has exited JVMTI_PHASE_PRIMORDIAL, and
PostVMInitHook happened to be one of those classes.
Since we already test a few other classes such as java/util/Locale,
the fix is simply to remove PostVMInitHook from the test.
Thanks
- Ioi
s***@oracle.com
2018-11-27 21:08:41 UTC
Permalink
Hi Ioi,

It looks good and trivial.

Thanks,
Serguei
Post by Ioi Lam
https://bugs.openjdk.java.net/browse/JDK-8213275
http://cr.openjdk.java.net/~iklam/jdk12/8213275-ReplaceCriticalClasses-missing-PostVMInitHook.v01/
Please review this simple fix. The jdk.internal.vm.PostVMInitHook
class is not in the openjdk so it should be used in a test in the
openjdk repo.
It isn't important to test for this particular class. When I wrote the
test, I was just looking for a few classes that are loaded immediately
after JVMTI has exited JVMTI_PHASE_PRIMORDIAL, and PostVMInitHook
happened to be one of those classes.
Since we already test a few other classes such as java/util/Locale,
the fix is simply to remove PostVMInitHook from the test.
Thanks
- Ioi
Loading...