<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Looks good.<br>
<br>
Chris<br>
<br>
On 12/1/18 3:10 AM, <a class="moz-txt-link-abbreviated" href="mailto:***@oracle.com">***@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:84625284-712a-52a0-9024-***@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="moz-cite-prefix">Updated webrev:<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Egadams/8214300/webrev.01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~gadams/8214300/webrev.01/</a><br>
<br>
On 11/30/18 3:10 PM, Chris Plummer wrote:<br>
</div>
<blockquote type="cite"
cite="mid:df2d4d3c-9076-0402-f885-***@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<div class="moz-cite-prefix">...and I've been waiting for the
webrev update to give it a thumbs up.<br>
<br>
Chris<br>
<br>
On 11/30/18 1:11 AM, <a class="moz-txt-link-abbreviated"
href="mailto:***@oracle.com" moz-do-not-send="true">***@oracle.com</a>
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:95b85891-5acb-6a16-b8a8-***@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<div class="moz-cite-prefix">I have not refreshed the webrev,
yet.<br>
Waiting to see if there are any additional comments<br>
before updating the webrev.<br>
<br>
The spaces and the assignments you noticed<br>
have been fixed.<br>
<br>
On 11/29/18 5:27 PM, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGBwE9T=-=EXpkPoyV+***@mail.gmail.com">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<div dir="ltr">Hi Gary,
<div><br>
</div>
<div>Somehow I still see the same webrev? Has it been
updated and my browser does not want to update it?</div>
<div><br>
</div>
<div>Thanks!</div>
<div>Jc</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Nov 29, 2018 at 11:10 AM Gary Adams
<<a href="mailto:***@oracle.com"
moz-do-not-send="true">***@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Sorry, coding
before coffee this morning.<br>
<br>
Fixed.<br>
<br>
On 11/29/18, 11:54 AM, JC Beyler wrote:
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">Hi Gary,
<div><br>
</div>
<div>Is there a reason why only <a
href="http://cr.openjdk.java.net/%7Egadams/8214300/webrev.00/src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html"
target="_blank" moz-do-not-send="true">http://cr.openjdk.java.net/~gadams/8214300/webrev.00/src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java.udiff.html</a>
actually has the assignment after the call ?</div>
<div>f = f.getCanonicalFile()?</div>
<div><br>
</div>
<div>(Nit, there seems to be a space missing
before the =).</div>
<div><br>
</div>
<div>In the other two files, you just call the
method but don't update the variable f making
the call useless, no? (The patch in the bug
has the assigments for all the cases),</div>
<div>Jc</div>
<div><br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Nov 29, 2018 at 8:23 AM
Gary Adams <<a
href="mailto:***@oracle.com"
target="_blank" moz-do-not-send="true">***@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0
0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">If a process exits
during an attempt to attach to it, the
.attach_pid file<br>
will not be removed properly, if the path used
included symbolic link <br>
traversal,<br>
which is typically done for
"/proc/<pid>/cwd/". Using
getCanonicalFile() <br>
before the<br>
initial file is created should prevent this edge
case for left over files.<br>
<br>
Webrev: <a
href="http://cr.openjdk.java.net/%7Egadams/8214300/webrev.00/index.html"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://cr.openjdk.java.net/~gadams/8214300/webrev.00/index.html</a><br>
Issue: <a
href="https://bugs.openjdk.java.net/browse/JDK-8214300"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8214300</a><br>
<br>
Testing is in progress for every attach test I
can find, but there is no<br>
explicit test available for the case where the
attachee exits while the <br>
attacher<br>
is making the initial connection.<br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr"
class="m_-1606696362352808152gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</blockquote>
<p><br>
</p>
</blockquote>
<p><br>
</p>
</blockquote>
<p><br>
</p>
</body>
</html>