RFR (L) 8214502: Add space after/before {} in remaining vmTestbase tests

Discussion:

JC Beyler

2018-11-30 04:10:49 UTC

Hi all,

Could I get a review for adding a space around the {} for the vmTestbase.
This webrev handles all remaining cases for vmTestbase :-)

Here is the webrev and bug:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8214502/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8214502

Thanks for your help!
Jc

David Holmes

2018-11-30 04:21:20 UTC

Permalink

Looks good!

I only examined what you changed, I did not try to see if you had missed
anything :)

Thanks,
David

Post by JC Beyler
Hi all,
Could I get a review for adding a space around the {} for the
vmTestbase. This webrev handles all remaining cases for vmTestbase :-)
Webrev: http://cr.openjdk.java.net/~jcbeyler/8214502/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8214502
Thanks for your help!
Jc

JC Beyler

2018-11-30 05:12:37 UTC

Permalink

Thanks David :)

For reference:
jdk12-spaces/test/hotspot/jtreg/vmTestbase$ grep "{[^ }]" `find . -name
"*cpp"`
./nsk/stress/jni/gclocker/libgcl001.cpp:{\
jdk12-spaces/test/hotspot/jtreg/vmTestbase$ grep "[^ {]}" `find . -name
"*cpp"`
./nsk/share/jvmti/jvmti_tools.cpp: //}

Have a great evening,
Jc

Post by David Holmes
Looks good!
I only examined what you changed, I did not try to see if you had missed
anything :)
Thanks,
David

--
Thanks,
Jc

s***@oracle.com

2018-11-30 06:26:11 UTC

Permalink

Hi Jc,

+1

Thanks,
Serguei

Post by David Holmes
Looks good!
I only examined what you changed, I did not try to see if you had
missed anything :)
Thanks,
David