RFR (L) 8211782: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[I-S]*

[JC Beyler]

Hi all,

I continued the NSK_CPP_STUB removal with this webrev:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8211782/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8211782

This does another 50 file batch. I added the steps and scripts in this bug
as well so that you can see what was done. Some extra long lines happen and
I'm working on seeing if I can detect that ahead of time but it might
remain a manual step every time.

I've tested the modified changes on my machine, all modified tests pass.

Let me know what you think,
Jc

[s***@oracle.com]

Hi Jc,

It looks good to me.

Thanks,
Serguei

Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8211782/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8211782/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8211782
This does another 50 file batch. I added the steps and scripts in this
bug as well so that you can see what was done. Some extra long lines
happen and I'm working on seeing if I can detect that ahead of time
but it might remain a manual step every time.
I've tested the modified changes on my machine, all modified tests pass.
Let me know what you think,
Jc

[Alex Menkov]

Looks good.

For some reason one statement in
nsk/jvmti/RetransformClasses/retransform003/retransform003.cpp
(@@ -105,92 +97,35 @@)
was not converted to 1-liner like others in the same file:
+ if (!NSK_VERIFY((loader_class = jni->GetObjectClass(loader)
) != NULL
)
)
Could you please fix it (no need other round of review)

--alex

Post by s***@oracle.com
Hi Jc,
It looks good to me.
Thanks,
Serguei

Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8211782/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8211782/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8211782
This does another 50 file batch. I added the steps and scripts in this
bug as well so that you can see what was done. Some extra long lines
happen and I'm working on seeing if I can detect that ahead of time
but it might remain a manual step every time.
I've tested the modified changes on my machine, all modified tests pass.
Let me know what you think,
Jc

[JC Beyler]

Thanks both,

I pushed it with Alex' minor fix,
Jc

Post by Alex Menkov
Looks good.
For some reason one statement in
nsk/jvmti/RetransformClasses/retransform003/retransform003.cpp
+ if (!NSK_VERIFY((loader_class = jni->GetObjectClass(loader)
) != NULL
)
)
Could you please fix it (no need other round of review)
--alex

Post by s***@oracle.com
Hi Jc,
It looks good to me.
Thanks,
Serguei

Post by JC Beyler
Hi all,
Webrev: http://cr.openjdk.java.net/~jcbeyler/8211782/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8211782/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8211782
This does another 50 file batch. I added the steps and scripts in this
bug as well so that you can see what was done. Some extra long lines
happen and I'm working on seeing if I can detect that ahead of time
but it might remain a manual step every time.
I've tested the modified changes on my machine, all modified tests pass.
Let me know what you think,
Jc