Discussion:
RFR (L) 8214149: Move out assignments when not using NSK*VERIFY macros
(too old to reply)
JC Beyler
2018-11-21 00:27:01 UTC
Permalink
Hi all,

As we work out the details for removing the NSK*VERIFY macros and the
assignments in ifs in those cases, here is a webrev for assignments without
the macros.

Webrev: http://cr.openjdk.java.net/~jcbeyler/8210687/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8214149

I've launched testing for the whole vmTestbase test suite since this
touched a few shared files. I don't expect any surprises :-).

Note that, technically, we could also do the alternative of adding the
macros for each if statement instead :). I'd rather just move the
assignments out and then, as we agree about how to roll out a better
tracing/verification mechanism across the vmTestbase code base, we will
automatically encompass these and thus add coverage at that moment.

Thanks,
Jc
Chris Plummer
2018-11-21 03:44:11 UTC
Permalink
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi JC,<br>
<br>
Looks great. Thanks for the cleanup.<br>
<br>
Chris<br>
<br>
<br>
On 11/20/18 4:27 PM, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGBwfRr1RFsMZQnX9ouW1MPYr-bu1v4=UVyBbMT83O=***@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>As we work out the details for removing the NSK*VERIFY
macros and the assignments in ifs in those cases, here is
a webrev for assignments without the macros.</div>
<div><br>
</div>
<div>Webrev: <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8210687/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8210687/webrev.00/</a></div>
<div>Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8214149"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8214149</a></div>
<div><br>
</div>
<div>I've launched testing for the whole vmTestbase test
suite since this touched a few shared files. I don't
expect any surprises :-).</div>
<div><br>
</div>
<div>Note that, technically, we could also do the
alternative of adding the macros for each if statement
instead :). I'd rather just move the assignments out and
then, as we agree about how to roll out a better
tracing/verification mechanism across the vmTestbase code
base, we will automatically encompass these and thus add
coverage at that moment.
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>
s***@oracle.com
2018-11-21 04:27:38 UTC
Permalink
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Jc,<br>
<br>
++(LG+TFTC)<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 11/20/18 19:44, Chris Plummer wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c122ad41-5429-ab42-73e5-***@oracle.com">
<div class="moz-cite-prefix">Hi JC,<br>
<br>
Looks great. Thanks for the cleanup.<br>
<br>
Chris<br>
<br>
<br>
On 11/20/18 4:27 PM, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGBwfRr1RFsMZQnX9ouW1MPYr-bu1v4=UVyBbMT83O=***@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>As we work out the details for removing the
NSK*VERIFY macros and the assignments in ifs in those
cases, here is a webrev for assignments without the
macros.</div>
<div><br>
</div>
<div>Webrev: <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8210687/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8210687/webrev.00/</a></div>
<div>Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8214149"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8214149</a></div>
<div><br>
</div>
<div>I've launched testing for the whole vmTestbase test
suite since this touched a few shared files. I don't
expect any surprises :-).</div>
<div><br>
</div>
<div>Note that, technically, we could also do the
alternative of adding the macros for each if statement
instead :). I'd rather just move the assignments out and
then, as we agree about how to roll out a better
tracing/verification mechanism across the vmTestbase
code base, we will automatically encompass these and
thus add coverage at that moment.
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</blockquote>
<br>
</body>
</html>
JC Beyler
2018-11-21 18:50:21 UTC
Permalink
Thanks both,

Tested on dev machine & submit repo and pushed,
Jc
Post by s***@oracle.com
Hi Jc,
++(LG+TFTC)
Thanks,
Serguei
Hi JC,
Looks great. Thanks for the cleanup.
Chris
Hi all,
As we work out the details for removing the NSK*VERIFY macros and the
assignments in ifs in those cases, here is a webrev for assignments without
the macros.
Webrev: http://cr.openjdk.java.net/~jcbeyler/8210687/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8214149
I've launched testing for the whole vmTestbase test suite since this
touched a few shared files. I don't expect any surprises :-).
Note that, technically, we could also do the alternative of adding the
macros for each if statement instead :). I'd rather just move the
assignments out and then, as we agree about how to roll out a better
tracing/verification mechanism across the vmTestbase code base, we will
automatically encompass these and thus add coverage at that moment.
Thanks,
Jc
--
Thanks,
Jc
Loading...