Hi Thomas and JC , thanks for the reviews !
Best regards, Matthias
From: JC Beyler <***@google.com>
Sent: Dienstag, 27. November 2018 16:48
To: Baesken, Matthias <***@sap.com>
Cc: hotspot-dev Source Developers <email@example.com>; firstname.lastname@example.org
Subject: Re: RFR : [XS] 8214373: adjust usage of ReleaseLongArrayElements in MacosxDebuggerLocal
Not a reviewer but looks good to me :). I checked if other releases were not in the right place and they all seemed good as well.
On Tue, Nov 27, 2018 at 7:09 AM Baesken, Matthias <***@sap.com<mailto:***@sap.com>> wrote:
Hello, please review this small fix .
In MacosxDebuggerLocal.m , at a few places the functions GetLongArrayElements and ReleaseLongArrayElements are used.
However there is one place where in an early return the ReleaseLongArrayElements call has been forgotten .
Additionally at another place ReleaseLongArrayElements is at the wrong place (although this is probably not a big issue currently).