Discussion:
RFR : [XS] 8214373: adjust usage of ReleaseLongArrayElements in MacosxDebuggerLocal
(too old to reply)
Baesken, Matthias
2018-11-27 15:08:32 UTC
Permalink
Hello, please review this small fix .

In MacosxDebuggerLocal.m , at a few places the functions GetLongArrayElements and ReleaseLongArrayElements are used.

However there is one place where in an early return the ReleaseLongArrayElements call has been forgotten .

Additionally at another place ReleaseLongArrayElements is at the wrong place (although this is probably not a big issue currently).


Bug/webrev:

https://bugs.openjdk.java.net/browse/JDK-8214373

http://cr.openjdk.java.net/~mbaesken/webrevs/8214373.0/



Thanks, Matthias
JC Beyler
2018-11-27 15:47:42 UTC
Permalink
Hi Matthias,

Not a reviewer but looks good to me :). I checked if other releases were
not in the right place and they all seemed good as well.
Jc
Post by Baesken, Matthias
Hello, please review this small fix .
In MacosxDebuggerLocal.m , at a few places the functions
GetLongArrayElements and ReleaseLongArrayElements are used.
However there is one place where in an early return the
ReleaseLongArrayElements call has been forgotten .
Additionally at another place ReleaseLongArrayElements is at the wrong
place (although this is probably not a big issue currently).
https://bugs.openjdk.java.net/browse/JDK-8214373
http://cr.openjdk.java.net/~mbaesken/webrevs/8214373.0/
Thanks, Matthias
--
Thanks,
Jc
Baesken, Matthias
2018-11-28 08:18:19 UTC
Permalink
Hi Thomas and JC , thanks for the reviews !

Best regards, Matthias


From: JC Beyler <***@google.com>
Sent: Dienstag, 27. November 2018 16:48
To: Baesken, Matthias <***@sap.com>
Cc: hotspot-dev Source Developers <hotspot-***@openjdk.java.net>; serviceability-***@openjdk.java.net
Subject: Re: RFR : [XS] 8214373: adjust usage of ReleaseLongArrayElements in MacosxDebuggerLocal

Hi Matthias,

Not a reviewer but looks good to me :). I checked if other releases were not in the right place and they all seemed good as well.
Jc

On Tue, Nov 27, 2018 at 7:09 AM Baesken, Matthias <***@sap.com<mailto:***@sap.com>> wrote:
Hello, please review this small fix .

In MacosxDebuggerLocal.m , at a few places the functions GetLongArrayElements and ReleaseLongArrayElements are used.

However there is one place where in an early return the ReleaseLongArrayElements call has been forgotten .

Additionally at another place ReleaseLongArrayElements is at the wrong place (although this is probably not a big issue currently).


Bug/webrev:

https://bugs.openjdk.java.net/browse/JDK-8214373

http://cr.openjdk.java.net/~mbaesken/webrevs/8214373.0/



Thanks, Matthias
--
Thanks,
Jc
Thomas Stüfe
2018-11-27 16:46:38 UTC
Permalink
Hi Matthias,

looks fine.

How did you find this, via Coverity?

... Thomas

On Tue, Nov 27, 2018 at 4:09 PM Baesken, Matthias
Post by Baesken, Matthias
Hello, please review this small fix .
In MacosxDebuggerLocal.m , at a few places the functions GetLongArrayElements and ReleaseLongArrayElements are used.
However there is one place where in an early return the ReleaseLongArrayElements call has been forgotten .
Additionally at another place ReleaseLongArrayElements is at the wrong place (although this is probably not a big issue currently).
https://bugs.openjdk.java.net/browse/JDK-8214373
http://cr.openjdk.java.net/~mbaesken/webrevs/8214373.0/
Thanks, Matthias
Loading...