Discussion:
[8u] RFR: 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647
(too old to reply)
Severin Gehwolf
2018-11-15 19:31:13 UTC
Permalink
Hi,

When the SA optimization fix got backported to JDK 11 a build issue on
Windows 32 bit was discovered by SAP. This would be the JDK 8
equivalent for the old build system. Note that the JDK 8 build still
uses GZ which is deprecated since at least Visual Studio 2012[1]. So
I've replaced it with RTC1. This backport patch depends on [2] which
got reviewed already.

Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.02/

Testing: Build on 32 bit Windows done by Alex Kashchenko.

Thoughts?

Thanks,
Severin

[1] https://msdn.microsoft.com/en-us/library/hddybs7t.aspx
[2] http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023918.html
Erik Joelsson
2018-11-15 19:39:53 UTC
Permalink
Looks good to me.

/Erik
Post by Severin Gehwolf
Hi,
When the SA optimization fix got backported to JDK 11 a build issue on
Windows 32 bit was discovered by SAP. This would be the JDK 8
equivalent for the old build system. Note that the JDK 8 build still
uses GZ which is deprecated since at least Visual Studio 2012[1]. So
I've replaced it with RTC1. This backport patch depends on [2] which
got reviewed already.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.02/
Testing: Build on 32 bit Windows done by Alex Kashchenko.
Thoughts?
Thanks,
Severin
[1] https://msdn.microsoft.com/en-us/library/hddybs7t.aspx
[2] http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023918.html
Alex Kashchenko
2018-11-16 00:32:48 UTC
Permalink
Hi Severin
Post by Erik Joelsson
Looks good to me.
/Erik
Post by Severin Gehwolf
Hi,
When the SA optimization fix got backported to JDK 11 a build issue on
Windows 32 bit was discovered by SAP. This would be the JDK 8
equivalent for the old build system. Note that the JDK 8 build still
uses GZ which is deprecated since at least Visual Studio 2012[1]. So
I've replaced it with RTC1. This backport patch depends on [2] which
got reviewed already.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.02/
In this line:

SA_CFLAGS = $(SA_CFLAGS) -ZI

"ZI" should be changed to "Zi", otherwise it fails on fastdebug and
release (not compatible with O2).
Post by Erik Joelsson
Post by Severin Gehwolf
[...]
--
-Alex
Severin Gehwolf
2018-11-16 08:53:21 UTC
Permalink
Hi Alex,

Hi Alex,
Post by Alex Kashchenko
Hi Severin
Post by Erik Joelsson
Looks good to me.
/Erik
Post by Severin Gehwolf
Hi,
When the SA optimization fix got backported to JDK 11 a build issue on
Windows 32 bit was discovered by SAP. This would be the JDK 8
equivalent for the old build system. Note that the JDK 8 build still
uses GZ which is deprecated since at least Visual Studio 2012[1]. So
I've replaced it with RTC1. This backport patch depends on [2] which
got reviewed already.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.02/
SA_CFLAGS = $(SA_CFLAGS) -ZI
"ZI" should be changed to "Zi", otherwise it fails on fastdebug and
release (not compatible with O2).
Nice catch! How about this?

http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.03/

Thanks,
Severin
Alex Kashchenko
2018-11-16 12:14:45 UTC
Permalink
Post by Severin Gehwolf
Hi Alex,
Hi Alex,
Post by Alex Kashchenko
Hi Severin
Post by Erik Joelsson
Looks good to me.
/Erik
Post by Severin Gehwolf
Hi,
When the SA optimization fix got backported to JDK 11 a build issue on
Windows 32 bit was discovered by SAP. This would be the JDK 8
equivalent for the old build system. Note that the JDK 8 build still
uses GZ which is deprecated since at least Visual Studio 2012[1]. So
I've replaced it with RTC1. This backport patch depends on [2] which
got reviewed already.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.02/
SA_CFLAGS = $(SA_CFLAGS) -ZI
"ZI" should be changed to "Zi", otherwise it fails on fastdebug and
release (not compatible with O2).
Nice catch! How about this?
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.03/
This worked for me.
--
-Alex
Severin Gehwolf
2018-11-16 13:35:16 UTC
Permalink
Post by Alex Kashchenko
Post by Severin Gehwolf
Post by Alex Kashchenko
SA_CFLAGS = $(SA_CFLAGS) -ZI
"ZI" should be changed to "Zi", otherwise it fails on fastdebug and
release (not compatible with O2).
Nice catch! How about this?
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.03/
This worked for me.
Great, thanks!

Cheers,
Severin

Loading...