[8u] RFR for 'JDK-8195088: [TEST_BUG] StartManagementAgent got unexpected exception'

Discussion:

Shafi Ahmad

2018-01-29 12:31:32 UTC

Hi,

Please review the trivial code change for the fix of 'JDK-8195088: [TEST_BUG] StartManagementAgent got unexpected exception' to jdk8u-dev.

Summary:
This test case is expected to fail but the expected exception message is different.
This fix
- if (!ex.getMessage().contains("Invalid com.sun.management.jmxremote.port number")) {
+ if (!ex.getMessage().contains("NumberFormatException: For input string: \"apa\"")) {

is checking for the correct message.

This is fixed in jdk10 under bug JDK-8165736 [Error message should be shown when JVMTI agent cannot be attache] http://hg.openjdk.java.net/jdk/hs/rev/bc1cffa26561#l10.1

Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8195088
webrev link: http://cr.openjdk.java.net/~shshahma/8195088/webrev.00/

Regards,
Shafi

Shafi Ahmad

2018-02-06 05:56:25 UTC

Permalink

Hi,

Could someone please review it.

Regards,
Shafi

-----Original Message-----
From: Shafi Ahmad
Sent: Monday, January 29, 2018 6:02 PM
Subject: [8u] RFR for 'JDK-8195088: [TEST_BUG] StartManagementAgent got
unexpected exception'
Hi,
Please review the trivial code change for the fix of 'JDK-8195088: [TEST_BUG]
StartManagementAgent got unexpected exception' to jdk8u-dev.
This test case is expected to fail but the expected exception message is different.
This fix
- if (!ex.getMessage().contains("Invalid
com.sun.management.jmxremote.port number")) {
+ if (!ex.getMessage().contains("NumberFormatException: For input
string: \"apa\"")) {
is checking for the correct message.
This is fixed in jdk10 under bug JDK-8165736 [Error message should be shown
when JVMTI agent cannot be attache]
http://hg.openjdk.java.net/jdk/hs/rev/bc1cffa26561#l10.1
Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8195088
webrev link: http://cr.openjdk.java.net/~shshahma/8195088/webrev.00/
Regards,
Shafi

Chris Plummer

2018-02-06 22:27:54 UTC

Permalink

Hi Shafi,

A simple change with a complex history. It looks like you are
backporting just the test modification that was done in JDK 10 for
JDK-8165736. And this is needed in 8u because of the JDK-8188865 and
JDK-8179643 backports that resulted in a similar change to the error
output that JDK-8165736 did. I'm not quite seeing the entire backport
picture here, but I wonder why you don't backport all of JDK-8165736.

cheers,

Chris

Post by Shafi Ahmad
Hi,
Could someone please review it.
Regards,
Shafi

David Holmes

2018-02-15 04:58:09 UTC

Permalink

Reviewed.

Thanks,
David

Post by Shafi Ahmad
Hi,
Could someone please review it.
Regards,
Shafi